CamEra Posted March 24, 2009 Share Posted March 24, 2009 Hi, I want to write a script to ftp all the log files in a directory to our ftp server - no problem there. I intend to use the GetFileNameList to get a list of names and then to ftp them in sequence and as each file is successfully transferred to move the file to an archive directory using File.MoveFile. The potential problem with this scheme is that the present logging file will be open and shouldn't be ftp'ed or moved. Is there any way to know if a file is locked? One of the reasons to do it this way is that if any files are missed one day e.g. the ftp server is down, the internet link is down etc. then they will just be picked up the next day. If all goes to plan there should be only one file per day to transfer - I have my logging file created on a daily basis. Thanks Link to comment Share on other sites More sharing options...
AzeoTech Posted March 26, 2009 Share Posted March 26, 2009 You can just look at the strFileName variable of the logging set to see which one it is working with. Link to comment Share on other sites More sharing options...
CamEra Posted March 26, 2009 Author Share Posted March 26, 2009 Thanks, in fact, it came to me in a flash of brilliance last night. Link to comment Share on other sites More sharing options...
CamEra Posted March 29, 2009 Author Share Posted March 29, 2009 Hi, well, didn't quite work as expected. My logging setup has a base file of "C:\Tanks\Tank.txt" but I have asked for it to add on the time so I get a file like "Tank_090330_112324.txt". When I use the code below to get the file name it gives me the name as "C:\Tanks\Tank.txt" without the time portion. My idea here is that I want to ftp any data files that have been closed to my ftp server, as each one is ftp'ed I want to copy it to an archive directory - this all works, I have just commented it out here. The present file will be open so I cannot ftp that file so want to skip it. Due to Windows way of getting file names the latest file could be the first in the list or the last or anywhere in fact. Another thing, is it possible to get the full year as part of the file name - after year 2000 problems I now prefer to work with 4 characters for the year always. Thanks ftp.strServer = "xxx" ftp.strUserName = "xxx" ftp.strPassword = "xxx" ftp.timeout=30000 private.strMyFiles=File.GetFileNameList("c:\tanks\*.txt") if (NumRows(private.strMyFiles) >1) private.fHandle=file.Open("c:\tanks\FilestoFTP.txt",0,1,1,1) file.Write(private.fHandle,doubletostr(NumRows(private.strMyFiles))) file.Write(private.fHandle, FormatDateTime("%d/%m/%Y",systime())) file.Write(private.fHandle,Logging.datalog.strFileName) // for (private.Count=0, private.count<NumRows(private.strMyFiles),private.count++) // ftp.strLocalFile = "c:\tanks\" + private.strMyFiles(private.count) // if (Logging.datalog.strFileName != "c:\tanks\" + private.strMyFiles(private.count)) // ftp.strRemoteFile = "/incoming/RuakuraTanks/" + private.strMyFiles(private.count) // file.Write(private.fHandle,ftp.strRemoteFile) // ftp.Upload() // if (ftp.BytesTransfered == -1) // File.MoveFile("c:\tanks\" + private.strMyFiles(private.count),"c:\tanks\archive\" + private.strMyFiles(private.count)) // Endif // Endif // endfor file.Write(private.fHandle,"") file.Close(private.fHandle) endif Link to comment Share on other sites More sharing options...
AzeoTech Posted March 30, 2009 Share Posted March 30, 2009 I'm not really sure I understand the problem. Where are you setting the date to the end of the filename? Maybe you can post an example of what strMyFiles and logging.datalog.strFileName contain. As for four digit year, if you are using formatdatetime() there is a specifier for the four digit year. It is %Y (Y in caps). Doing lower case: %y gives you just the 2 digit year. Link to comment Share on other sites More sharing options...
CamEra Posted March 30, 2009 Author Share Posted March 30, 2009 Hi, A couple of screen shots provided of my logging setup. On the Main tab I have set the file name as C:\Tanks\Tanks.txt on the details tab I have ticked the "Use Date in File Name" box on the "Details" tab - second image. The system logs every 15 minutes and creates a new file every day. I presumed DaqFactory had added the date and time parts to the data files. Outut to my log file is - with my notes underlined Note - this is a log before I tried to counter the problem of trying to ftp the file in use 3 25/03/2009 c:\tanks\Tank_080915_143727.txt /incoming/payne/tankdata/Tank_080915_143727.txt c:\tanks\Tank_080915_144759.txt /incoming/payne/tankdata/Tank_080915_144759.txt Note - this is the code as at present, it counts the number of output files, adds todays date and then outputs the name of the present log file 9 30/03/2009 C:\Tanks\Tanks.txt Hope this helps you understand my problem. Thanks Link to comment Share on other sites More sharing options...
AzeoTech Posted March 30, 2009 Share Posted March 30, 2009 Gotcha. Don't use AutoSplit files for this. For one thing, it will only work the way you expect if you happen to start the logging set at midnight. If you start it midday, each of your daily log files will contain some data from one day and some from the next. Autosplit files is designed for people that are running in environments where harddrive crashes are more likely (airplanes mostly). By splitting the log files into small files, you lower the chance of losing large chunks of data in a harddrive crash. Instead, you should change the log filename yourself from script. This is talked about it elsewhere (forum, docs?) and so I assumed you were using this method. Create a sequence that runs all the time and has a priority of 0: while(1) logging.datalog.strFileName = formatdatetime("C:\tanks\tanks%d%m%Y.txt",systime()) delay(1) endwhile Look up the formatdatetime() function in the expression chapter to see how you can format your date. This is day, month, and 4 digit year. The script constantly updates the filename of the logging set based on the current time, but since the result of the function only changes once a day, you get a new logging file once a day. The logging set automatically closes the log file and opens another whenever the strFileName variable changes. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.